Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running VIBRATIONS_CALIBRATION after AXIS_MAP_CALIBRATION cause error #55

Closed
1 task done
j16sdiz opened this issue Jan 29, 2024 · 2 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@j16sdiz
Copy link

j16sdiz commented Jan 29, 2024

K-Shake&Tune module branch

  • I confirm using the main branch

Version

v2.5.0-3-geab10ce5

Describe the bug and expected behavior

The script took *-axemap.csv as a vibration test output. It should be ignored.

Additional information and klippy.log

raise ValueError("File %s does not contain speed in its name and therefore "
ValueError: File /home/biqu/printer_data/config/K-ShakeTune_results/vibrations/vibr_20240129_155151-axemap.csv does not contain speed in its name and therefore is not supported by this script.
15:52:07
raw_speeds = [extract_speed(filename) for filename in lognames]
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/graph_vibrations.py", line 327, in extract_speed
15:52:07
create_vibrations_graph(axis_name=options.axis_name, accel=options.accel_used, chip_name=options.chip_name, keep_csv=options.keep_csv)
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/is_workflow.py", line 165, in create_vibrations_graph
fig = vibrations_calibration(lognames, KLIPPER_FOLDER, axis_name, accel)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/graph_vibrations.py", line 353, in vibrations_calibration
raw_speeds = [extract_speed(filename) for filename in lognames]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/graph_vibrations.py", line 353, in
15:52:07
speed = re.search('sp(.+?)n', os.path.basename(logname)).group(1).replace('_','.')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/is_workflow.py", line 299, in
main()
File "/home/biqu/klippain_shaketune/K-ShakeTune/scripts/is_workflow.py", line 288, in main
@j16sdiz j16sdiz added the bug Something isn't working label Jan 29, 2024
@Frix-x
Copy link
Owner

Frix-x commented Feb 9, 2024

Yes, this is indeed a known issue due to the fact that the AXE_MAP_CALIBRATION variable is quite experimental and its level of integration is not on par with the other macros: it currently does not clean up the /tmp folder and that's why this bug happens. I have it in my backlog to fix it in the next version :)

@Frix-x
Copy link
Owner

Frix-x commented May 12, 2024

I'm closing this issue in favor of #99 that is a duplicate of the AXES_MAP_CALIBRATION not working correctly. The feature will soon be fixed. In the meantime, avoid using it, the rest should work correctly.

@Frix-x Frix-x closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants