Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#253 window install failed #260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xiaoliwang
Copy link

@xiaoliwang xiaoliwang commented Aug 25, 2022

Fixes #253

  1. Remove undefined method Binary::setInput and DependencyLib::setInput
  2. Support Additional .ini Path
  3. Support deplister.exe not in Path
  4. Implementing PHPUnzipper function exttactTo

@excitedbox
Copy link

box fails at compiling your fix to a phar. please post a release to your fork.

@gphg
Copy link

gphg commented Dec 20, 2022

This PR fixed the issue I'm having on Windows. Please merge this PR as soon as possible.

box fails at compiling your fix to a phar. please post a release to your fork.

I managed to build .phar file from this PR and install redis PHP extension myself. As listened on phpredis INSTALL.md. Here the procedure how I build this:

  1. get box installed.
    • The box2 version listed on README.md abandoned.
    • On my side, I get it installed as a composer global package.
  2. git clone the source repo, then cd pickle
  3. install required dependencies: composer install --no-dev --optimize-autoloader
    • On Windows's cmd, it might fails because it requires patch.exe. I had to switch to Git's bash.exe shell.
  4. execute box build

The binary is available under bin directory.

This is the output on how I install redis.

> bin\pickle.bat install redis
+---------------+----------------------+
| php Path      | C:\xampp\php\php.exe |
| php Version   | 7.4.33               |
| Compiler      | vc15                 |
| Architecture  | x64                  |
| Thread safety | yes                  |
| Extension dir | C:\xampp\php\ext     |
| php.ini       | C:\xampp\php\php.ini |
+---------------+----------------------+
downloading https://windows.php.net/downloads/pecl/releases/redis/5.3.7/php_redis-5.3.7-7.4-ts-vc15-x64.zip
 667099/667099 [============================] 100%Extracting archives...
copying C:\xampp\tmp\pickle-redis\php_redis.dll to C:\xampp\php\ext\php_redis.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window install failed
3 participants