New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frogger Jump location preview [bounty: 4 XTR] #2574
Comments
I'm glad to do this one |
Sure, will assign soon.
…On Tue, Apr 30, 2024, 9:22 PM Terminalman ***@***.***> wrote:
I'm glad to do this one
—
Reply to this email directly, view it on GitHub
<#2574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEPNX3J72F6CEKT65PNYXTY77OMXAVCNFSM6AAAAABGYSUDHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBWGQYTMOJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@DreadKnight this one seems good to go, but just a quick question. At the bottom of the hexgrid code I found a function called fadeOutTempCreature that has a comment above it mentioning factoring it out but it seems to do exactly what we need when using the previewCreature function so I used it for this ability. Does this seem ok? |
@gg447062 Took a peek at it. Well, ideally it would be to do things as indicated in the comment there it seems 🐻 AncientBeast/src/utility/hexgrid.ts Line 1669 in 159d4df
|
Ok from what I can tell, that function is only used twice so I don't think it should cause too much chaos to refactor it. I think the thing that confused me about the comment was that it mentions the existing temp creature created by /src/abilities/Dark-Priest.js but unless I'm totally off the temp creature is this.materialize_overlay, which is also not an instance of Creature.creatureSprite. |
@gg447062 Comment could be wrong, I'm not sure. Feel free to poke at it and make a PR 🐻 |
@DreadKnight Ok sounds good, I'm going to submit a PR for this one for now. |
Fixed in ##2580 |
As follow-up to issue #2533 's fix, Uncle Fungus's Frogger Jump ability could show up transparent cardboard preview to the hovered target location
The text was updated successfully, but these errors were encountered: