Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abolished Fiery Touch throws error when used facing left #2442

Open
andretchen0 opened this issue Jul 19, 2023 · 1 comment
Open

Abolished Fiery Touch throws error when used facing left #2442

andretchen0 opened this issue Jul 19, 2023 · 1 comment
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming
Milestone

Comments

@andretchen0
Copy link
Contributor

Description

When using the Abolished creature's "Fiery Touch" move while the creature is facing left, an error is thrown:

target is undefined

I believe this is a long-standing error. I checked through several months of commits and all exhibit the same error.

There is no target in the path here:

const target = arrayUtils.last(path).creature;

That's as far up the call stack as I've looked.

To reproduce

Here's a game log. Paste it into the browser console.

AB.restoreGame("Ancient Beast 0.5.0 GameLog | Generated on 2023-07-19 ||{"actions":[{"action":"ability","target":{"type":"hex","x":4,"y":3},"id":3,"args":{"1":{"creature":"P7","cost":10},"2":{"queryOptions":{"args":{"creature":"P7","cost":10},"hexes":[{"x":2,"y":0},{"x":1,"y":0},{"x":0,"y":0},{"x":2,"y":1},{"x":1,"y":1},{"x":0,"y":1},{"x":3,"y":1},{"x":2,"y":1},{"x":1,"y":1},{"x":2,"y":2},{"x":1,"y":2},{"x":0,"y":2},{"x":3,"y":2},{"x":2,"y":2},{"x":1,"y":2},{"x":2,"y":3},{"x":1,"y":3},{"x":0,"y":3},{"x":3,"y":3},{"x":2,"y":3},{"x":1,"y":3},{"x":4,"y":3},{"x":3,"y":3},{"x":2,"y":3},{"x":3,"y":4},{"x":2,"y":4},{"x":1,"y":4},{"x":4,"y":4},{"x":3,"y":4},{"x":2,"y":4},{"x":2,"y":5},{"x":1,"y":5},{"x":0,"y":5},{"x":3,"y":5},{"x":2,"y":5},{"x":1,"y":5},{"x":4,"y":5},{"x":3,"y":5},{"x":2,"y":5},{"x":2,"y":6},{"x":1,"y":6},{"x":0,"y":6},{"x":3,"y":6},{"x":2,"y":6},{"x":1,"y":6},{"x":2,"y":7},{"x":1,"y":7},{"x":0,"y":7},{"x":3,"y":7},{"x":2,"y":7},{"x":1,"y":7},{"x":2,"y":8},{"x":1,"y":8},{"x":0,"y":8}],"hexesDashed":[],"shrunkenHexes":[],"hexesDeadZone":[],"size":3,"id":0,"flipped":false,"hideNonTarget":false,"ownCreatureHexShade":false,"targeting":true,"fillHexOnHover":true}}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":13,"y":6},"id":3,"args":{"1":{"creature":"P7","cost":10},"2":{"queryOptions":{"args":{"creature":"P7","cost":10},"hexes":[{"x":14,"y":0},{"x":13,"y":0},{"x":12,"y":0},{"x":14,"y":1},{"x":13,"y":1},{"x":12,"y":1},{"x":15,"y":1},{"x":14,"y":1},{"x":13,"y":1},{"x":13,"y":2},{"x":12,"y":2},{"x":11,"y":2},{"x":14,"y":2},{"x":13,"y":2},{"x":12,"y":2},{"x":13,"y":3},{"x":12,"y":3},{"x":11,"y":3},{"x":14,"y":3},{"x":13,"y":3},{"x":12,"y":3},{"x":15,"y":3},{"x":14,"y":3},{"x":13,"y":3},{"x":12,"y":4},{"x":11,"y":4},{"x":10,"y":4},{"x":13,"y":4},{"x":12,"y":4},{"x":11,"y":4},{"x":13,"y":5},{"x":12,"y":5},{"x":11,"y":5},{"x":14,"y":5},{"x":13,"y":5},{"x":12,"y":5},{"x":15,"y":5},{"x":14,"y":5},{"x":13,"y":5},{"x":13,"y":6},{"x":12,"y":6},{"x":11,"y":6},{"x":14,"y":6},{"x":13,"y":6},{"x":12,"y":6},{"x":14,"y":7},{"x":13,"y":7},{"x":12,"y":7},{"x":15,"y":7},{"x":14,"y":7},{"x":13,"y":7},{"x":14,"y":8},{"x":13,"y":8},{"x":12,"y":8}],"hexesDashed":[],"shrunkenHexes":[],"hexesDeadZone":[],"size":3,"id":0,"flipped":true,"hideNonTarget":false,"ownCreatureHexShade":false,"targeting":true,"fillHexOnHover":true}}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":3,"y":6},"id":3,"args":{"1":{"creature":"P3","cost":5},"2":{"queryOptions":{"args":{"creature":"P3","cost":5},"hexes":[{"x":1,"y":0},{"x":0,"y":0},{"x":2,"y":0},{"x":1,"y":0},{"x":1,"y":1},{"x":0,"y":1},{"x":2,"y":1},{"x":1,"y":1},{"x":3,"y":1},{"x":2,"y":1},{"x":1,"y":2},{"x":0,"y":2},{"x":2,"y":2},{"x":1,"y":2},{"x":3,"y":2},{"x":2,"y":2},{"x":1,"y":3},{"x":0,"y":3},{"x":2,"y":4},{"x":1,"y":4},{"x":3,"y":4},{"x":2,"y":4},{"x":4,"y":4},{"x":3,"y":4},{"x":1,"y":5},{"x":0,"y":5},{"x":2,"y":5},{"x":1,"y":5},{"x":3,"y":5},{"x":2,"y":5},{"x":4,"y":5},{"x":3,"y":5},{"x":1,"y":6},{"x":0,"y":6},{"x":2,"y":6},{"x":1,"y":6},{"x":3,"y":6},{"x":2,"y":6},{"x":1,"y":7},{"x":0,"y":7},{"x":2,"y":7},{"x":1,"y":7},{"x":3,"y":7},{"x":2,"y":7},{"x":1,"y":8},{"x":0,"y":8},{"x":2,"y":8},{"x":1,"y":8}],"hexesDashed":[],"shrunkenHexes":[],"hexesDeadZone":[],"size":2,"id":0,"flipped":false,"hideNonTarget":false,"ownCreatureHexShade":false,"targeting":true,"fillHexOnHover":true}}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":12,"y":3},"id":3,"args":{"1":{"creature":"P3","cost":5},"2":{"queryOptions":{"args":{"creature":"P3","cost":5},"hexes":[{"x":13,"y":0},{"x":12,"y":0},{"x":14,"y":0},{"x":13,"y":0},{"x":13,"y":1},{"x":12,"y":1},{"x":14,"y":1},{"x":13,"y":1},{"x":15,"y":1},{"x":14,"y":1},{"x":12,"y":2},{"x":11,"y":2},{"x":13,"y":2},{"x":12,"y":2},{"x":14,"y":2},{"x":13,"y":2},{"x":12,"y":3},{"x":11,"y":3},{"x":13,"y":3},{"x":12,"y":3},{"x":14,"y":3},{"x":13,"y":3},{"x":15,"y":3},{"x":14,"y":3},{"x":11,"y":4},{"x":10,"y":4},{"x":12,"y":4},{"x":11,"y":4},{"x":13,"y":4},{"x":12,"y":4},{"x":12,"y":5},{"x":11,"y":5},{"x":13,"y":5},{"x":12,"y":5},{"x":14,"y":5},{"x":13,"y":5},{"x":15,"y":5},{"x":14,"y":5},{"x":13,"y":7},{"x":12,"y":7},{"x":14,"y":7},{"x":13,"y":7},{"x":15,"y":7},{"x":14,"y":7},{"x":13,"y":8},{"x":12,"y":8},{"x":14,"y":8},{"x":13,"y":8}],"hexesDashed":[],"shrunkenHexes":[],"hexesDeadZone":[],"size":2,"id":0,"flipped":true,"hideNonTarget":false,"ownCreatureHexShade":false,"targeting":true,"fillHexOnHover":true}}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":8,"y":6}},{"action":"skip"},{"action":"move","target":{"x":8,"y":3}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":5,"y":3},{"x":6,"y":3},{"x":7,"y":3},{"x":8,"y":3}]},"id":1,"args":{"1":{"direction":1,"hex":{"x":7,"y":3},"choiceIndex":0},"2":{"queryOptions":{"team":1,"requireCreature":true,"id":2,"args":{"direction":1,"hex":{"x":7,"y":3},"choiceIndex":0},"flipped":false,"choices":[[{"x":5,"y":3},{"x":6,"y":3},{"x":7,"y":3},{"x":8,"y":3}]],"hexesDashed":[],"hexesDeadZone":[],"shrunkenHexes":[{"x":8,"y":3}],"isDirectionsQuery":true,"hideNonTarget":true,"dashedHexesUnderCreature":false,"x":4,"y":3,"directions":[1,1,1,1,1,1],"includeCreature":true,"stopOnCreature":true,"distance":3,"minDistance":0,"distanceFalloff":3,"dashedHexesAfterCreatureStop":true,"dashedHexesDistance":0,"sourceCreature":{}}}}},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":7,"y":6},{"x":8,"y":6},{"x":9,"y":6},{"x":10,"y":6}]},"id":1,"args":{"1":{"direction":4,"hex":{"x":8,"y":6},"choiceIndex":0},"2":{"queryOptions":{"team":1,"requireCreature":true,"id":3,"args":{"direction":4,"hex":{"x":8,"y":6},"choiceIndex":0},"flipped":true,"choices":[[{"x":7,"y":6},{"x":8,"y":6},{"x":9,"y":6},{"x":10,"y":6}]],"hexesDashed":[],"hexesDeadZone":[],"shrunkenHexes":[{"x":10,"y":6}],"isDirectionsQuery":true,"hideNonTarget":true,"dashedHexesUnderCreature":false,"x":13,"y":6,"directions":[1,1,1,1,1,1],"includeCreature":true,"stopOnCreature":true,"distance":3,"minDistance":0,"distanceFalloff":3,"dashedHexesAfterCreatureStop":true,"dashedHexesDistance":0,"sourceCreature":{}}}}}],"version":"0.5.0","date":"2023-07-19T22:36:47.868Z","custom":{"configData":{"playerMode":2,"creaLimitNbr":3,"unitDrops":1,"abilityUpgrades":3,"plasma_amount":30,"turnTimePool":-1,"timePool":-60,"background_image":"Shadow Cave","combatLocation":"Shadow Cave","fullscreenMode":false}}}")
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone Jul 20, 2023
@DreadKnight DreadKnight added coding This issue requires some programming abilities The issue is related to an unit ability or more labels Jul 20, 2023
@andretchen0 andretchen0 removed their assignment Aug 4, 2023
@JoelFernandes09
Copy link
Contributor

Looked into this a bit & I think the wider fix is to convert these files to TS & implement the functions since I think a lot of stuff has been refactored. I found out that there's a temp fix in Chimera, Gumble & more that fixes this issue. Should I open a PR with the same fix for this since it will be playable for the time being? Also do we have conversion issues for files that aren't TS yet?

@andretchen0 @DreadKnight

@DreadKnight DreadKnight pinned this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming
Projects
None yet
Development

No branches or pull requests

3 participants