Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to save searches #1505

Open
toby63 opened this issue Jul 8, 2021 · 2 comments · May be fixed by #5003
Open

Ability to save searches #1505

toby63 opened this issue Jul 8, 2021 · 2 comments · May be fixed by #5003
Assignees
Labels
enhancement New feature or request

Comments

@toby63
Copy link

toby63 commented Jul 8, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
Sometimes I like to search for videos and playlists on broader topics (e.g.: Countries, Music Genres, Games etc.) and I would like to have a list of these searches.

Describe the solution you'd like to see implemented
Probably:

  • a menu item called "Searches" or "Search Favorites" (or something that sounds better): This would include the list of searches
  • a button on the "Search Results" page to add the search to the list

Unlike a recent history of searches, this would only include handpicked favorites.

Describe alternatives you've considered

Screenshots

Additional context

@toby63 toby63 added the enhancement New feature or request label Jul 8, 2021
@PrestonN PrestonN added this to To assign in Feature Requests Jul 8, 2021
@efb4f5ff-1298-471a-8973-3d47447115dc

we can maybe do this combined with #1492.

maybe put a star at the right side of the recent searches and if u want to save that one u can press on the star.

@jasonhenriquez
Copy link
Collaborator

jasonhenriquez commented Apr 21, 2024

My alternative suggestion for this implementation:

Problem description
I often want to be able to go to a specific remote playlist, already-opened playlist, channel, or generic page in FreeTube. The workflow I have to support this is writing a set of links in an external text editor and copying & pasting those links into the search bar. It would be convenient if I didn't have to do this.

Proposed suggestion

  • General proposal:
    • The ability to bookmark routes (not just keyword searches) through a button on the top nav
    • Be able to set a named alias for those bookmarks through a modal popup
    • When the current route is saved, it shows as starred in the top nav
    • Clicking on the top nav for a bookmarked route opens a modal allowing you to edit the name and/or remove the bookmark
    • Searching for a substring of a bookmark link or alias in the search bar shows the corresponding bookmarks at the top of the search results, with some type of visual (& ARIA) identifier
    • Delete all bookmarks setting in Privacy Settings
  • Subsequent PRs:

Implementation discussion

  • Bookmarking a generic route would be easiest if we could just put a FreeTube route into the search bar.
    • Pros:
      • Easiest
      • Most easily extensible
    • Cons:
      • I don't believe this is currently implemented, and I'm not sure of the level of difficulty
      • Will potentially cause bookmarks to break across versions if our routes change, unless we added code programmatically updating the bookmarks in each such breaking change
  • Alternative: grabbing the corresponding Share link (from the preferred backend?) corresponding to the given route
    • Pros:
      • Certainly possible
      • Doesn't require us to add new type of search processing
    • Cons:
      • Will take more manual work to extract the proper share link for each given route
      • Bars non-shareable links from being bookmarked

@jasonhenriquez jasonhenriquez self-assigned this Apr 22, 2024
@jasonhenriquez jasonhenriquez linked a pull request Apr 23, 2024 that will close this issue
1 task
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Feature Requests
Low Priority
Development

Successfully merging a pull request may close this issue.

3 participants