Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Update label casing to sentence case #5000

Open
3 tasks done
jasonhenriquez opened this issue Apr 22, 2024 · 3 comments
Open
3 tasks done

[Feature Request]: Update label casing to sentence case #5000

jasonhenriquez opened this issue Apr 22, 2024 · 3 comments
Labels
E: visual improvement enhancement New feature or request PR: low priority For pull requests that don't require a fast review. e.g. code cleanup

Comments

@jasonhenriquez
Copy link
Collaborator

jasonhenriquez commented Apr 22, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Our labels throughout FreeTube vary between sentence case and title case. There is no consistency, and this can at times be mildly jarring visually.

Proposed Solution

Standardize all labels in FreeTube under sentence case, the one preferred by many style guides (see discussion here as well). We can do this either programmatically or manually (which sounds terrible). If programmatically, apply to all elements descending from the root of the document - this should take one rule, and maybe getting rid of any text-transforms elsewhere if they clash with this vision. Any exceptions to this rule should be exceptionally rare. I don't think we can write exceptions for labels starting with a word that should be lowercase given our large amount of supported languages, but that's fine. Of course, this does not apply to modifying user-generated content, unless we're talking about Display Titles Without Excessive Capitalisation And Punctuation, which @efb4f5ff-1298-471a-8973-3d47447115dc has rightly called out needs to be retested with the implementation of this feature.

Test modals and sections throughout the app to confirm that there are no issues with visually portraying the hierarchy with this change. If there are any, use additional styling like bolding and minor size differentials to resolve them.

Alternatives Considered

None

Issue Labels

visual improvement

Additional Information

No response

@jasonhenriquez jasonhenriquez added the enhancement New feature or request label Apr 22, 2024
@FreeTubeBot FreeTubeBot added this to To assign in Feature Requests Apr 22, 2024
@jasonhenriquez jasonhenriquez added PR: low priority For pull requests that don't require a fast review. e.g. code cleanup good first issue Good for newcomers labels Apr 22, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

I think Distraction free setting: Display Titles Without Excessive Capitalisation And Punctuation should be retested in PR

@jasonhenriquez jasonhenriquez removed the good first issue Good for newcomers label May 4, 2024
@jasonhenriquez
Copy link
Collaborator Author

Removing "good first issue" as I feel like it might take some thought on how to actually do this. If we do it programmatically, for example, how would that affect languages like German, where capitalization is often necessary? We could probably have a set of languages not included, but then that's going beyond new contributor territory.

@jasonhenriquez
Copy link
Collaborator Author

To do it programmatically, we'd also need a set of proper nouns saved to know not to make lowercase. It seems almost like a manual solution for EN-US would be better, then just hope that translations in other languages where sentence casing is preferred follow suit. I don't know of any better options at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: visual improvement enhancement New feature or request PR: low priority For pull requests that don't require a fast review. e.g. code cleanup
Projects
Development

No branches or pull requests

2 participants