FreeRDP-2.11.6 fails to compile with GCC-14: incompatible pointer types in unicode.c

[NHOrus]

Error:

/var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c: In function ‘MultiByteToWideChar’:
/var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c:218:63: error: passing argument 3 of ‘ucnv_convert’ from incompatible pointer type [-Wincompatible-pointer-types]
  218 |                             ucnv_convert("UTF-16LE", "UTF-8", targetStart, targetCapacity * sizeof(WCHAR),
      |                                                               ^~~~~~~~~~~
      |                                                               |
      |                                                               LPWSTR {aka short unsigned int *}
In file included from /var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c:34:
/usr/include/unicode/ucnv.h:1581:20: note: expected ‘char *’ but argument is of type ‘LPWSTR’ {aka ‘short unsigned int *’}
 1581 |              char *target,
      |              ~~~~~~^~~~~~
/var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c: In function ‘WideCharToMultiByte’:
/var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c:356:83: error: passing argument 5 of ‘ucnv_convert’ from incompatible pointer type [-Wincompatible-pointer-types]
  356 |                         targetLength = ucnv_convert("UTF-8", "UTF-16LE", NULL, 0, lpWideCharStr,
      |                                                                                   ^~~~~~~~~~~~~
      |                                                                                   |
      |                                                                                   LPCWSTR {aka const short unsigned int *}
/usr/include/unicode/ucnv.h:1583:26: note: expected ‘const char *’ but argument is of type ‘LPCWSTR’ {aka ‘const short unsigned int *’}
 1583 |              const char *source,
      |              ~~~~~~~~~~~~^~~~~~
/var/tmp/portage/net-misc/freerdp-2.11.6/work/freerdp-2.11.6/winpr/libwinpr/crt/unicode.c:363:53: error: passing argument 5 of ‘ucnv_convert’ from incompatible pointer type [-Wincompatible-pointer-types]
  363 |                                                     lpWideCharStr, cchWideChar * sizeof(WCHAR), &error);
      |                                                     ^~~~~~~~~~~~~
      |                                                     |
      |                                                     LPCWSTR {aka const short unsigned int *}
/usr/include/unicode/ucnv.h:1583:26: note: expected ‘const char *’ but argument is of type ‘LPCWSTR’ {aka ‘const short unsigned int *’}
 1583 |              const char *source,
      |              ~~~~~~~~~~~~^~~~~~

Environment (please complete the following information):

• OS: Gentoo Linux Testing
• Architecture: AMD 64
  CMakeConfigureLog.txt

[akallabeth]

pull requests welcome, but we only fix security issues on oldstable ourselves.

[floppym]

Gentoo is working around this for now by passing -Wno-error=incompatible-pointer-types via CFLAGS.