Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZoneIanaAbbrevMap.c requires patching to compile with GCC14 #10176

Closed
vp1981 opened this issue May 10, 2024 · 1 comment
Closed

TimeZoneIanaAbbrevMap.c requires patching to compile with GCC14 #10176

vp1981 opened this issue May 10, 2024 · 1 comment

Comments

@vp1981
Copy link

vp1981 commented May 10, 2024

Hello.

I'm on Archlinux x86_64 with GCC14 and glibc 2.39. To compile freerdp from git I have to apply the following patch to winpr/libwinpr/timezone/TimeZoneIanaAbbrevMap.c:

diff --git a/winpr/libwinpr/timezone/TimeZoneIanaAbbrevMap.c b/winpr/libwinpr/timezone/TimeZoneIanaAbbrevMap.c
index 7bc28719b..0ce7e4fa1 100644
--- a/winpr/libwinpr/timezone/TimeZoneIanaAbbrevMap.c
+++ b/winpr/libwinpr/timezone/TimeZoneIanaAbbrevMap.c
@@ -129,7 +129,7 @@ static void iterate_subdir_recursive(const char* base, const char* bname, const
 	if (!path)
 		return;
 
-	struct DIR* d = opendir(path);
+	DIR* d = opendir(path);
 	if (d)
 	{
 		struct dirent* dp = NULL;

According to opendir(3) it should be DIR *, but not struct DIR *.

@akallabeth akallabeth added this to the next-3.0 milestone May 11, 2024
@akallabeth
Copy link
Member

same as #10175, pull requests welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants