Fix macapp build with homebrew (needs a FreeCAD fix) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vejmarie <jmverdun3@gmail.com>
This was
linked to
issues
Apr 12, 2021
|
I don't understand the icu4-stuff of this PR. 1. Set env PKG_CONFIG_PATH The result of this line
should be every time '/lib/pgkconfig'. Better way:
2. In CMakeLists.txt the relevant source code is comment out in your branch
|
|
Inreplace solution. Testing welcome. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the creation of the MacApp when using homebrew. Needs currently some fixes into freecad tree into src/MacAppBundle/CMakeLists.txt which is lacking a few includes to build the bundle.
For pure testing you can use https://github.com/vejmarie/FreeCAD -> branch macbundle
It will successfully create the FreeCAD.app which can be copied into /Applications (it is rellocatable) and then successfully used.
Let me know your thoughts !
Signed-off-by: vejmarie jmverdun3@gmail.com