Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketcher: Can't join two arcs #13645

Open
2 tasks done
dancesWithMachines opened this issue Apr 25, 2024 · 7 comments
Open
2 tasks done

Sketcher: Can't join two arcs #13645

dancesWithMachines opened this issue Apr 25, 2024 · 7 comments
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench

Comments

@dancesWithMachines
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Scenario:

  1. Create one half of the arc and constrain it.
  2. Add second arc using same point as center and join the "arms".

Expected results:
Arcs are joined together, sketch is constrained.

Actual result:
Cannot join the arcs.

Visual:
ScreenRecording2024-04-25at18 16 33-ezgif com-video-to-gif-converter

Full version info

[code]
OS: macOS 14.4
Word size of FreeCAD: 64-bit
Version: 0.21.2.33771 (Git)
Build type: Release
Branch: (HEAD detached at 0.21.2)
Hash: b9bfa5c5507506e4515816414cd27f4851d00489
Python 3.10.13, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.6, OCC 7.6.3
Locale: C/Default (C)
[/code]

Subproject(s) affected?

Sketcher

Anything else?

I believe this is a regression.
Two arcs cannot be joined in FreeCad 21.0+.
I verified this on 20.2 and it would be over-constrained but work.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 25, 2024

can you check if you have enabled the setting auto remove constraints and play with it on/off?
Could you please also test this in the current dev version: https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds

@maxwxyz maxwxyz added WB Sketcher Related to the Sketcher Workbench Missing: feedback If feedback is requested labels Apr 25, 2024
@dancesWithMachines
Copy link
Author

can you check if you have enabled the setting auto remove constraints and play with it on/off?

I had auto remove redundants enabled by default. I disabled it and now it behaves like this.
On 21.2 I get over-constrain error like below.
ScreenRecording2024-04-25at19 01 42-ezgif com-video-to-gif-converter

On 20.02 I initially get same error, but if I try to move the sketch it resolves.
ScreenRecording2024-04-25at18 58 49-ezgif com-video-to-gif-converter

Could you please also test this in the current dev version: https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds

On newest dev-build (36958-2024-04-23 ) it just crashes and exits.
ScreenRecording2024-04-25at19 17 45-ezgif com-video-to-gif-converter

Crash log from devbuild: freecad_crash.zip

@maxwxyz maxwxyz added Bug This issue or PR is related to a bug and removed Missing: feedback If feedback is requested labels Apr 25, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 25, 2024

@PaddleStroke FYI

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 25, 2024 via email

@dancesWithMachines
Copy link
Author

In this particular scenario equal can be used to achieve same result, but this feels like workaround'ing. From logical point of view I don't see why joining two arcs would not work, it isn't intuitional.
ScreenRecording2024-04-25at22 56 00-ezgif com-video-to-gif-converter
ScreenRecording2024-04-25at22 56 43-ezgif com-video-to-gif-converter

@dancesWithMachines
Copy link
Author

The scenario from this bug is very simple, but I originally come up from this.
ScreenRecording2024-04-25at23 20 33-ezgif com-video-to-gif-converter
Here the outcome is different, depending on what I do first.

@PaddleStroke
Copy link
Contributor

I totally agree that this feels very much like a bug. I have argued that in the past.
I'm just not sure how to solve it. Anyone know how other Cads are handling this situation?

Maybe we need to add an exceptions in the solver for coincidence constraints for cases where arcs have 3 coincidences. Something like :

if (arc has 3 coincidence)
      ignore one dof of center coincidence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

3 participants