Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum: emoji size out of proportion in default theme (also when not signed-in) #61

Open
luzpaz opened this issue Dec 21, 2020 · 19 comments · Fixed by #62
Open

Forum: emoji size out of proportion in default theme (also when not signed-in) #61

luzpaz opened this issue Dec 21, 2020 · 19 comments · Fixed by #62

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Dec 21, 2020

Issue: https://forum.freecadweb.org/viewtopic.php?t=32722
image

Console warning:

This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. viewtopic.php
Source map error: Error: request failed with status 404
Resource URL: https://forum.freecadweb.org/styles/freecad/theme/stylesheet.css?assets_version=30
Source Map URL: stylesheet.css.map

This is the expected behavior: switch over to the elegance theme (i'm using the Firefox 'Dark Reader' addon hence the dark theme)
image

@luzpaz
Copy link
Collaborator Author

luzpaz commented Feb 8, 2021

@yorikvanhavre the class selectors are .emoji .smilies

@luzpaz
Copy link
Collaborator Author

luzpaz commented Feb 14, 2021

/cc @yorikvanhavre @kkremitzki

@luzpaz
Copy link
Collaborator Author

luzpaz commented Feb 19, 2021

This is still an issue, reopening
case in point: https://forum.freecadweb.org/viewtopic.php?f=8&t=55645&p=479829#p479829
image

@luzpaz luzpaz reopened this Feb 19, 2021
@luzpaz
Copy link
Collaborator Author

luzpaz commented Feb 19, 2021

Maybe the _common.scss files are being overwritten ?

@luzpaz
Copy link
Collaborator Author

luzpaz commented Feb 27, 2021

Ok, it just needed to be pushed to the server. This issue is fixed!

@luzpaz
Copy link
Collaborator Author

luzpaz commented Mar 6, 2021

stylesheet doesn't apply to those not logged in.

  1. log out of forum
  2. browse https://forum.freecadweb.org/viewtopic.php?f=3&t=56319#p484442

@luzpaz luzpaz changed the title Forum: emoji size out of proportion in default theme Forum: emoji size out of proportion in default theme (also when not signed-in) Apr 1, 2021
@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 1, 2021

image

@ipatch
Copy link

ipatch commented Apr 13, 2021

logged in and emojis are still rendering larger than normal.

image

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 13, 2021

seriously?

@ipatch
Copy link

ipatch commented Apr 13, 2021

seriously?

as a heart attack. 💔

@ipatch
Copy link

ipatch commented Apr 13, 2021

it's not related to failing to load the sourcempa is it.

image

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 14, 2021

Can you make sure by logging in and hard refreshing pages that have the 'newer' emojis on them?
Also would you mind experimenting with different forum themes (changing them in the settings)?

@ipatch
Copy link

ipatch commented Apr 21, 2021

just tried with vivaldi, chrome, and firefox, logged in, not logged in still the same. is there a github repo that hosts the phpbb code for the forum? i might be able to take a look at the source and see if i can find anything out of the norm.

image

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 21, 2021

@yorikvanhavre can you weigh in?

@ipatch
Copy link

ipatch commented Apr 21, 2021

i forgot i posted this thread in the forum a while back,

https://forum.freecadweb.org/viewtopic.php?f=8&t=52663

so i guess all the styling for the forum and wiki are contained within this git repo. 👍

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 22, 2021

Indeed. I have merge permissions on this repo...so feel free to submit PRs and I'll test them.

@ipatch
Copy link

ipatch commented Apr 22, 2021

that emoji class you added to the stylesheet isn't being added to the stylesheet when i visit the freecad forum, as evident when viewing the assets for the forum in this image below,

image

if you do a search for .inner:after in the sources tab of the browser tools you'll see the .emoji class is never added to the stylesheet.

as evident from viewing the commit you made,

https://github.com/FreeCAD/FreeCAD-Homepage/blob/master/forum/styles/freecad/theme/_common.scss#L1936

the emoji class .emoji should appear within the stylesheet but does not. it also appears the styles are using sass ie. .scss which i believe need to be precompiled at some point before they can be served up to a normal (chrome,firefox) web browser before they well be rendered.

so if i had to take a shot in the dark maybe the assets haven't been compiled since you pushed your changes to this repo.

i don't know how this whole infrastructure works, in hwo the actual server picks the code from this repo and then renders it, so i can't really comment on that. but i hope this helps in further understanding of what is going on.

@luzpaz
Copy link
Collaborator Author

luzpaz commented May 15, 2021

@kkremitzki you have experience with sass?

@kkremitzki
Copy link
Member

Afraid not. This broke again because there were breaking changes to the theme our FreeCAD and FreeCAD-Dark themes are based on... it would be good to have something a little more maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants