Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum themes are using vendored copy instead of inheritance #161

Open
kkremitzki opened this issue Feb 18, 2024 · 2 comments
Open

Forum themes are using vendored copy instead of inheritance #161

kkremitzki opened this issue Feb 18, 2024 · 2 comments

Comments

@kkremitzki
Copy link
Member

The FreeCAD and FreeCAD-Dark forum themes use a vendored copy of an upstream phpBB theme from an old version; the current version of phpBB has diverged from this copy, resulting in display issues. Instead of using a copy, these themes should use inheritance from the base theme, with the changes specific to our variant listed out directly, rather than existing as direct modifications to the theme's files. This is the proper fix to existing issues, and will result in more resilience to further upstream changes in future phpBB versions.

Reference: https://www.phpbb.com/styles/create/

@yorikvanhavre
Copy link
Member

I think we should remove these custom themes entirely as they are totally out of sync with current phpBB...
And then redo some themes the proper way, by just overriding the needed files...

@hasecilu
Copy link
Contributor

My main reason to use the custom themes was the dark mode, using "Dark Reader" extension takes care of this regard, the little icons on top to redirect to come FreeCAD sites would be nice to have them re-implemented, the ddg search is not a must have for me, the default onsite search works pretty good also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants