Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #61

Open
looooo opened this issue Mar 24, 2021 · 7 comments
Open

TODO #61

looooo opened this issue Mar 24, 2021 · 7 comments

Comments

@looooo
Copy link
Contributor

looooo commented Mar 24, 2021

just a little reminder to make the next release easier:

@luzpaz
Copy link
Collaborator

luzpaz commented Mar 24, 2021

Note: any changes you make may affect downstream services like:
chocolatey, fosstorrents, our website and wiki

@looooo
Copy link
Contributor Author

looooo commented Mar 25, 2021

@luzpaz
naming switched anyway for the next weekly builds. But this way we can continue having the same name and release to store the bundles. So this will make it easier for other services to work.

@antony-jr
Copy link

@looooo Also I see that you are using tag 0.19.1 (or the version) for AppImage update information for versioned releases but if you use latest tag then any AppImage updater will take the latest release from the releases and sync to it. For example anything marked with latest flag in releases will be synced. But this is not a high priority since everything is working as expected for now.

Please ping me in github if you need any help with AppImage packaging in Github actions.

@looooo
Copy link
Contributor Author

looooo commented Apr 1, 2021

@antony-jr what does latest reffer to? The latest uploaded appimage? Or the highest tag? Is it guaranteed that 0.19.1 appimage will not update to weekly-builds?

@antony-jr
Copy link

antony-jr commented Apr 1, 2021

@antony-jr what does latest reffer to? The latest uploaded appimage? Or the highest tag? Is it guaranteed that 0.19.1 appimage will not update to weekly-builds?

TL;DR: Yes the highest tag.

Yes. See the below image,

latest

The updater will use the tag which has that latest release flag as seen in the image above. So in this case 0.19.1 is the latest. This means even if you go to v0.20.0 there will be no disconnect on this. For Weekly builds we can continue using the weekly tag or whatever tag that is used for weekly builds.

@antony-jr
Copy link

antony-jr commented Apr 1, 2021

Is it guaranteed that 0.19.1 appimage will not update to weekly-builds?

No. If the weekly builds are released and it is the highest tag then it is the latest in theory so we just need to make sure that we don't have weekly builds release as the latest.

@looooo
Copy link
Contributor Author

looooo commented Apr 1, 2021

@antony-jr thanks. Can you review my commit:
066d766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants