Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Plug for Plug based applications #104

Open
arfl opened this issue Oct 15, 2018 · 3 comments
Open

Default Plug for Plug based applications #104

arfl opened this issue Oct 15, 2018 · 3 comments

Comments

@arfl
Copy link

arfl commented Oct 15, 2018

Hey guys.

In your documentation, you provide a whole section about using rollbax in Plug-based applications. How about adding a default plug implementation?
We could even copy & paste the implementation from the sentry.io project (MIT Licence) including tests.
Sure, we could write our own module (90% of the required code is in your documentation already), but we start new applications every 2-3 months and copy & paste this module all the time. We could write our own hex package just for this use case, but before we do this, I just want to ask you, if you could imagine adding a default plug implementation to rollbax directly? Should I submit a Pull Request?

@thbar
Copy link

thbar commented Feb 11, 2019

@arfl just curious, did you open-source your module somewhere ultimately?

@florish
Copy link
Contributor

florish commented Dec 31, 2019

Just to bump this one a bit: I've recently opened PR #115 and #116, both containing improvements in the example code for Plug-based applications.

In addition to the reasons stated above, for improvements like this, it would also be great to have a default implementation included in Rollbar, as it enables us to include fixes and improvements in new releases.

I'm willing to help with this if the rollbax maintainers are positive about such an addition!

@whatyouhide
Copy link
Contributor

Hey folks, PRs are welcome for this. Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants