Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on className with React 19 #560

Closed
Arkellys opened this issue May 9, 2024 · 4 comments
Closed

Error on className with React 19 #560

Arkellys opened this issue May 9, 2024 · 4 comments

Comments

@Arkellys
Copy link

Arkellys commented May 9, 2024

Describe the bug

On React 19 (beta), an error is thrown if className is not passed to <FontAwesomeIcon>.
I believe it's the same bug as the one reported on this issue, except that now it happens even when no className is specified.

Reproducible test case

https://codesandbox.io/p/sandbox/react-19-font-awesome-k6n8ww?file=%2Fsrc%2FApp.js%3A11%2C51

Error on the sandbox:

TypeError: className is undefined

I get a different error when I try it on my app (maybe it depends on the bundler config):

Uncaught TypeError: Cannot read properties of undefined (reading 'split')

Expected behavior

The error is fixed when adding a className, but this prop should not be required.

Setup

  • Browsers: Firefox (125.0.3), Electron (Chromium M124)
  • Font Awesome 6.5.2
  • react-fontawesome 0.2.0
  • React 19.0.0-beta-6946ebe620-20240508
@Arkellys
Copy link
Author

Arkellys commented May 9, 2024

I just noticed there is already a PR to fix this, hopefully it will be merged quickly.

@robmadole
Copy link
Member

I just released 0.2.1 which I think will fix this. Can you all retest?

@sakispirtos
Copy link

sakispirtos commented May 17, 2024

i just pulled down 0.2.1 and my application is now showing this error. i had to roll back to 0.2.0 to resolve. I'm using react 18.3.1, font awesome 6.5.2.

with 0.2.1 it wont fail if i supply a className, but my primary use-case doesn't supply unless its needed. Im fine with supplying if thats a new requirement.

@Arkellys
Copy link
Author

I just released 0.2.1 which I think will fix this. Can you all retest?

I can confirm that version 0.2.1 solves this issue on React 19, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants