Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch to zoom gesture blocked on iPhone #1020

Open
minervabot opened this issue May 14, 2023 · 1 comment
Open

Pinch to zoom gesture blocked on iPhone #1020

minervabot opened this issue May 14, 2023 · 1 comment

Comments

@minervabot
Copy link

Bugs and Questions

Describe Your Environment

  • What version of nuka-carousel are you using?
  • What version of React are you using?
  • What browser are you using?

"react": "18.2.0",
"nuka-carousel": "^6.0.3",

The browser is the most recent stable version of iOS Safari.

Describe the Problem

The drag handling prevents pinch to zoom gesture. This usually occurs when a touch event handler only worries about the first element of the touches[] array, instead of making sure there is only one element.

Expected behavior:

On mobile browsers it should be possible for people to quickly zoom in and back out on the carousel images. Multi touches should probably be ignored by the library.

Actual behavior

Multi finger touches act like a single finger touch.

Additional Information

@minervabot
Copy link
Author

I would be interested in working on a PR for this, as long as allowing pinch to zoom would be considered desirable behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants