Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag versioning #95

Closed
puria opened this issue Mar 11, 2024 · 7 comments
Closed

Fix tag versioning #95

puria opened this issue Mar 11, 2024 · 7 comments

Comments

@puria
Copy link
Member

puria commented Mar 11, 2024

No description provided.

@puria
Copy link
Member Author

puria commented May 31, 2024

Is this still an issue? @matteo-cristino in the last refactoring of actions, do you aligned the relase version with the build?

@matteo-cristino
Copy link
Contributor

I did, but this is still present. I think that the problem is that we have the version pushed with the new commit and since the ci is done on the prior commit, the new version is not there... But we use the same method for signroom, do we have correct version there or we are one back as here? 🤔

@matteo-cristino
Copy link
Contributor

I thought about a thing... maybe it can be resolved by simply using the actions/checkout with fetch-depth: 0. I will add the possiblity to set it in the dyne/pnpm action and will check if this solve the issue 🕵🏽

@matteo-cristino
Copy link
Contributor

Sadly fetch-depth: 0 does not solve the issue 😢 will look for another solution

@puria
Copy link
Member Author

puria commented Jun 4, 2024

@matteo-cristino ok don't worry I'll take care

@matteo-cristino
Copy link
Contributor

Issue still present, I think it can be caused by the fact that we are doing the build before the release now

- name: 🏗️ Build executable
run: |
make build
chmod +x ncr
- run: pnpm semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@puria
Copy link
Member Author

puria commented Jun 4, 2024

HECHO 🇪🇸

@puria puria closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants