If specified port is already taken, the app dies

[bbtgnn]

Add a human readable error to explain what's happening

[bbtgnn]

I'm having issues trying to reproduce the issue.

I launched:

• a server with python -m http.server 8000 --bind 0.0.0.0
• ncr with pnpm dev -p 8000 --hostname 0.0.0.0

But I don't get any errors. @puria do you have any ideas?

[puria]

No idea... then maybe should be something else... are you stil able to reproduce it by playing with the PORT variable in the .env file?

[puria]

OK! Yes I can do that also when you don't have permission to open the port... like use a port under 300...

[bbtgnn]

I tried to open it on port 200, but the application still works

[puria]

prova con la 80... a milano c'è il 🌞

[bbtgnn]

Non si rompe eheh

[puria]

È una bomba, l'ho sempre saputo! have you tried both from the .env and from the cli arguments?

[bbtgnn]

yuppp

[bbtgnn]

It seems to fail only when docker has taken the port.

The line of code responsible for the fail is this one:

ncr/src/index.ts

Line 81 in 7fc4b1f

const port = us_socket_local_port(socket);

I tried putting it in a try catch, but it doesn't catch – it just dies there.
@puria how should we address this? we should check the port before this point?

[puria]

@bbtgnn I guess that the environment variable PORT is clashing, plz rename all the variables to have more specific names eg. NCR_PORT

[bbtgnn]

I am not sure about it, cause I tried to run it with command line options

[puria]

The point is that docker uses the same env vriable that we use... namely: PORT
so docker and ncr both try to rear the same var... if you change it to PORT_NCR or something different that should be safer. If you try it and is not yet an issue, we can close this!