Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templavoila page contents not visible in backend when fluidpages is active #366

Open
cweiske opened this issue Sep 28, 2017 · 0 comments
Open

Comments

@cweiske
Copy link

cweiske commented Sep 28, 2017

Context

We've got a large TYPO3 v7 installation that has thousands of pages built with TemplaVoila. We're using https://github.com/alexanderschnitzler/templavoila/ as TemplaVoila-Extension. We're slowly switching to fluidpages+fluidcontent now, which means that both fluidpages and templavoila is used for page rendering.
New pages are built with fluidpages and get the page's "backend layout" setting set to "Fluid pages".

Problem

Every page (even if the backend layout is not set to "fluid pages") has the "Page Layouts" tab, and upon saving the tx_fed_page_controller_action field is saved. This is no problem for subpages because the empty-valued "Parent decides" section is there.
But for the root page misses this "Parent decides" page layout, and so the first fluidpages layout gets pre-selected. This means that simply changing the root page's title or TSconfig sets tx_fed_page_controller_action.

This leads to the problem that FluidTYPO3\Fluidpages\Provider\PageProvider::postProcessDataStructure (a hook called by flux flux' getFlexFormDS_postProcessDS) overwrites $dataStructArray even for pages that do not use the Fluidpages backend_layout.

In turn this means that TemplaVoila is unable to render the page content in "Web>TV Page" backend module.

Possible solution

FluidTYPO3\Fluidpages\Provider\PageProvider::getControllerActionReferenceFromRecord should check if the page's backend_layout (or parent pages backend_layout_next_level) is actually set to fluidpages__fluidpages.

I just see that PageService::getPageTemplateConfiguration should check that.

cweiske added a commit to mogic-le/fluidpages that referenced this issue Sep 29, 2017
When mixing both fluidpages and templavoila page layouts,
the page's backend_layout setting needs to be checked to
make sure that fluidpages is responsible for handling the
rendering.

Resolves: FluidTYPO3#366
cweiske added a commit to mogic-le/fluidpages that referenced this issue Oct 12, 2017
When mixing both fluidpages and templavoila page layouts,
the page's backend_layout setting needs to be checked to
make sure that fluidpages is responsible for handling the
rendering.

Resolves: FluidTYPO3#366
NamelessCoder pushed a commit to mogic-le/fluidpages that referenced this issue Oct 14, 2017
When mixing both fluidpages and templavoila page layouts,
the page's backend_layout setting needs to be checked to
make sure that fluidpages is responsible for handling the
rendering.

Resolves: FluidTYPO3#366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant