Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last page is not shown everytime #41

Open
erkenes opened this issue Feb 8, 2022 · 1 comment · May be fixed by #42
Open

Last page is not shown everytime #41

erkenes opened this issue Feb 8, 2022 · 1 comment · May be fixed by #42

Comments

@erkenes
Copy link

erkenes commented Feb 8, 2022 •
edited

If there is a pagination where "..." is displayed before the last page number, the last page number is not displayed when you are on the page where the "..." disappears.

I recognized this behavior in multiple projects and all had the same effect.

image1

image2
erkenes added a commit to erkenes/Flowpack.Listable that referenced this issue Feb 8, 2022
@erkenes
FIX: Last page is not shown everytime
5e03544 
If the "..." displayed before the last page number, the last page number was not displayed when you are on the page where the "..." disappears.

Check if the `displayRangeEnd + 1` matches the number of pages, if so add the last
page number then to the `links`-array

Resolves: Flowpack#41
@erkenes erkenes linked a pull request Feb 8, 2022 that will close this issue
Open
@erkenes
Copy link
Author

erkenes commented Feb 8, 2022

Here is a comparison how it looks like on page 11 from the first image with the changes from my pull request

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: Last page is not shown everytime erkenes/Flowpack.Listable
1 participant
@erkenes