Using wrong format in asset editing leads to unhelpful error message #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
Flix6x
approved these changes
Apr 11, 2021
| asset_form=asset_form, | ||
| asset=asset_info, |
There was a problem hiding this comment.
Why not hand over the asset object itself to Jinja? Then it would be easier to adjust asset.html (e.g. show a new asset property) without the need to also explicitly add it to the asset_info dict.
There was a problem hiding this comment.
The task at hand here is to give the form data to Jinja, so that invalid data can be properly displayed (for the user to be able to adjust it). The asset object is fresh from the database, not what the user just entered.
nhoening
changed the title
nhoening
deleted the
issue-89-Using_wrong_format_in_asset_editing_leads_to_unehlpful_error_message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #89
We improve the general ability of the asset edit form to display the invalid user input back to the user, so they can change their data.