New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6 entity address scheme improvements 2 #81
Conversation
…s_scheme_improvements_2
…s_scheme_improvements_2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your convenience, I left some comments while reviewing my own work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Also, a lot of work. I do feel bad asking for it, but some effort on the documentation side seems in order within this PR so that it reflects the level of attention the code gives to entity addresses.
I believe we can make a new page in the documentation without writing too much new content, see one of my comments.
… regex matches in parsing ea addresses
I think I'll make a new PR for that, also within 0.5.0
Am 21. Mai 2021 08:38:38 MESZ schrieb Felix Claessen ***@***.***>:
…
@Flix6x commented on this pull request.
> @@ -15,8 +15,8 @@
@pytest.mark.parametrize(
"post_message",
[
- message_for_post_price_data(),
- message_for_post_price_data(prior_instead_of_horizon=True),
+ message_for_post_price_data(market_id=7),
Great that you found out. Less autousing fixtures is generally a good
idea, so I am happy with that solution.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#81 (comment)
-- Gesendet von /e/ Mail.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The main changelog could use an entry, I guess under Infrastructure/Support.
- The API changelog also needs some entries, something along the line of:
- Updated all entity addresses in documentation according to the fm0 scheme, preserving backwards compatibility
- Introduced the fm1 scheme for entity addresses for connections, markets, weather sensors and sensors
While you're in the API changelog, could you please date |
closes #6