Issue 515 slow loading of asset page due to timerange query of its sensors #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and only use the timerange of shown sensors to set the date range if the date range isn't set by session variables already; minYear and maxYear are already set asynchronously after fetching the timerange Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 3470680784
💛 - Coveralls |
nhoening
approved these changes
Dec 1, 2022
Flix6x
deleted the
issue-515_Slow_loading_of_asset_page_due_to_timerange_query_of_its_sensors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes data load faster on the asset (and sensor) page. Most commonly, the time range is already set as session data, so we shouldn't have to wait for finishing a potentially slow query to the database that determines the full timerange of shown sensors.
Also, the date range selection on the calendar is now set much earlier, when initializing the calendar, instead of when the charts are done loading. This means that, when you navigate the calendar while charts are still loading, you don't annoyingly pop back to the initial selection when the charts are done loading.
Closes #515.