Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom requirements to docker compose #528

Merged
merged 7 commits into from Nov 11, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 1, 2022

To do:

  • Documentation regarding the possibility of adding custom requirements by adding a requirements.txt file to the flexmeasures-instance folder.
  • Changelog entry.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2022

Pull Request Test Coverage Report for Build 3437492834

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.023%

Totals Coverage Status
Change from base Build 3436864090: 0.0%
Covered Lines: 6562
Relevant Lines: 9474

💛 - Coveralls

@nhoening
Copy link
Contributor

nhoening commented Nov 1, 2022

Why is postgres-14 the one we should pin? It only happened to be the one you are using. I still think it's better than using the latest always, but this will then become outdated in a while. Maybe we need to think more about how we can pin down what FlexMeasures should support here and how to formalize that.

@Flix6x
Copy link
Contributor Author

Flix6x commented Nov 2, 2022

It's currently the most recent that didn't throw errors (for me) when running docker-compose up. Wouldn't it be preferable to be able to know exactly what postgres version users are running given a specific FlexMeasures version installed with docker?

@nhoening
Copy link
Contributor

nhoening commented Nov 2, 2022

Maybe it's an edge case that you created data in your own installation, then want to run it in another, docker-based one. But maybe it'll happen more often.

I agree that being specific is a little better, but the drawback is that this needs to be kept up-to-date, the one with a version not.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review November 10, 2022 14:10
@Flix6x Flix6x added this to the 0.12.0 milestone Nov 10, 2022
@Flix6x Flix6x merged commit 78b7e5e into main Nov 11, 2022
@Flix6x Flix6x deleted the add-custom-requirements-to-docker-compose branch November 11, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants