Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 504 prevent silently rounding off latitude and longitude values on asset page #522

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 1, 2022

Closes #504.

Signed-off-by: F.N. Claessen <felix@seita.nl>
…cimal places

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…l API

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working UI labels Nov 1, 2022
@Flix6x Flix6x self-assigned this Nov 1, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2022

Pull Request Test Coverage Report for Build 3380586700

  • 48 of 54 (88.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 65.095%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/schemas/assets.py 43 45 95.56%
flexmeasures/ui/crud/assets.py 0 4 0.0%
Totals Coverage Status
Change from base Build 3362189661: 0.1%
Covered Lines: 6546
Relevant Lines: 9444

💛 - Coveralls

@Flix6x Flix6x marked this pull request as ready for review November 1, 2022 13:40
@Flix6x Flix6x requested a review from nhoening November 1, 2022 13:41
@Flix6x
Copy link
Contributor Author

Flix6x commented Nov 1, 2022

If needed, I could separate the bug fixing commit (309b0d8) into a separate PR (for quick inclusion in the next release and also backporting). Let me know.

Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@Flix6x Flix6x added this to the 0.11.3 milestone Nov 2, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit eff83ff into main Nov 2, 2022
@Flix6x Flix6x deleted the issue-504_Prevent_silently_rounding_off_latitude_and_longitude_values_on_asset_page branch November 2, 2022 20:06
Flix6x added a commit that referenced this pull request Nov 2, 2022
…n AssetForm

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent silently rounding off latitude and longitude values on asset page
3 participants