Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduling with efficiencies #520

Merged
merged 6 commits into from Nov 2, 2022
Merged

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Oct 31, 2022

Fix scheduling with imperfect efficiencies, which resulted in exceeding the device's lower SoC limit.

…ersa

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening October 31, 2022 15:46
@Flix6x Flix6x self-assigned this Oct 31, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 31, 2022

Pull Request Test Coverage Report for Build 3380678204

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 64.986%

Totals Coverage Status
Change from base Build 3362189661: 0.005%
Covered Lines: 6519
Relevant Lines: 9416

💛 - Coveralls

@Flix6x
Copy link
Contributor Author

Flix6x commented Oct 31, 2022

Technically, we could backport this all the way to 0.8.x, in which scheduling under imperfect efficiencies was introduced (#291).

@Flix6x Flix6x added this to the 0.11.3 milestone Nov 2, 2022
flexmeasures/utils/calculations.py Outdated Show resolved Hide resolved
flexmeasures/utils/calculations.py Outdated Show resolved Hide resolved
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit bef845f into main Nov 2, 2022
@Flix6x Flix6x deleted the fix-scheduling-with-efficiencies branch November 2, 2022 20:07
Flix6x added a commit that referenced this pull request Nov 2, 2022
Fix scheduling with imperfect efficiencies, which resulted in exceeding the device's lower SoC limit.

* Apply efficiencies to conversion from flow to stock change and vice versa

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Reorder print statements for more convenient uncommenting

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix test

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Refactor: rename variables

Signed-off-by: F.N. Claessen <felix@seita.nl>

* changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Scheduling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants