Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduler for Charge Points #517

Merged
merged 2 commits into from Oct 31, 2022
Merged

Fix scheduler for Charge Points #517

merged 2 commits into from Oct 31, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Oct 31, 2022

Fix bug: list multiplication refers to the same object; as a consequence, any new device constraint overwrote all previously set device constraints.

@Flix6x
Fix bug: list multiplication refers to the same object; as a conseque…
e98a884 
…nce, any new device constraint overwrote all previously set device constraints

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Oct 31, 2022
@Flix6x Flix6x added this to the 0.11.3 milestone Oct 31, 2022
@Flix6x
changelog entry
da67e9b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review October 31, 2022 13:01
@coveralls
Copy link
Collaborator

coveralls commented Oct 31, 2022 •
edited

Pull Request Test Coverage Report for Build 3361449426

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 64.981%
Totals Coverage Status
Change from base Build 3350907541: 0.03%
Covered Lines: 6516
Relevant Lines: 9413
💛 - Coveralls

@Flix6x Flix6x requested a review from nhoening October 31, 2022 13:22
@Flix6x Flix6x merged commit b03d397 into main Oct 31, 2022
@Flix6x Flix6x deleted the fix-charge-point-scheduler branch October 31, 2022 14:44
Flix6x added a commit that referenced this pull request Nov 2, 2022
@Flix6x
Backport PR #517: Fix scheduler for Charge Points (#517)
e062a25 
* Fix bug: list multiplication refers to the same object; as a consequence, any new device constraint overwrote all previously set device constraints

Signed-off-by: F.N. Claessen <felix@seita.nl>

* changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
bug Something isn't working Scheduling
Projects
None yet
Milestone
0.11.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening