Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not resample data of sensors recording instantaneous values #491

Merged
merged 9 commits into from Sep 5, 2022
Merged

Do not resample data of sensors recording instantaneous values #491

merged 9 commits into from Sep 5, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Aug 29, 2022

Closes #490.

@Flix6x
Do not resample data of sensors recording instantaneous values
9841faf 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.11.1 milestone Aug 29, 2022
@Flix6x Flix6x self-assigned this Aug 29, 2022
@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2022 •
edited

Pull Request Test Coverage Report for Build 2993370487

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 65.101%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/charts/belief_charts.py 1 3 33.33%
flexmeasures/data/models/generic_assets.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/generic_assets.py 1 48.2%
Totals Coverage Status
Change from base Build 2992281182: -0.03%
Covered Lines: 6474
Relevant Lines: 9339
💛 - Coveralls

@Flix6x
Use linear interpolation for instantaneous sensors
747a5b2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
4c9ba24 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review August 31, 2022 10:31
@Flix6x
Fix tooltip
165a70a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening August 31, 2022 10:42
@Flix6x
Fix case with only instantaneous sensors
6b65f4a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge main
2c58b9b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening September 5, 2022 10:30
@Flix6x Flix6x added bug Something isn't working Still Needs Manual Backport labels Sep 5, 2022
nhoening
nhoening approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - Just one issue numbering problem.

documentation/changelog.rst Outdated Show resolved Hide resolved
@Flix6x
Fix changelog entry for PR #493 / Issue #492
ec4b750 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix changelog date format
2670da3 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add release date for 0.11.1
e86fbaa 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 2dfd080 into main Sep 5, 2022
@Flix6x Flix6x deleted the Issue-490_Error_resampling_to_resolution_of_sensors_recording_instantaneous_values branch September 5, 2022 12:56
Flix6x added a commit that referenced this pull request Sep 5, 2022
@Flix6x
Backport PR #491: Do not resample data of sensors recording instantan…
f0767ce 
…eous values (#491)

Do not fail asset page if one of the shown sensors records instantaneous values.

* Do not resample data of sensors recording instantaneous values

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use linear interpolation for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix tooltip

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix case with only instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog entry for PR #493 / Issue #492

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog date format

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Add release date for 0.11.1

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Sep 6, 2022
@Flix6x
Fix for bug introduced in PR #491
9316e12 
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Sep 6, 2022
@Flix6x
Fix for bug introduced in PR #491 (#498)
e20e0c1 
Fix a bug introduced in 0.11.1 when viewing the asset page with non-instantaneous sensors.


* Fix for bug introduced in PR #491

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Sep 6, 2022
@Flix6x
Backport PR #498: Fix for bug introduced in PR #491 (#498)
ab80ae8 
Fix a bug introduced in 0.11.1 when viewing the asset page with non-instantaneous sensors.

* Fix for bug introduced in PR #491

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

Error resampling to resolution of sensors recording instantaneous values
3 participants
@Flix6x @coveralls @nhoening