Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --custom-message param to flexmeasures monitor task CLI #489

Merged
merged 3 commits into from Aug 27, 2022
Merged

add --custom-message param to flexmeasures monitor task CLI #489

merged 3 commits into from Aug 27, 2022

Conversation

nhoening
Copy link
Contributor

Signed-off-by: Nicolas Höning nicolas@seita.nl

@nhoening
add --custom-message paramm to flexmeasures monitor task CLI
7d4b829 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening changed the title add --custom-message paramm to flexmeasures monitor task CLI add --custom-message param to flexmeasures monitor task CLI Aug 25, 2022
@nhoening nhoening added this to the 0.11.0 milestone Aug 25, 2022
@nhoening nhoening added the CLI label Aug 25, 2022
@nhoening nhoening requested a review from Flix6x August 25, 2022 15:40
@coveralls
Copy link
Collaborator

coveralls commented Aug 25, 2022 •
edited

Pull Request Test Coverage Report for Build 2929289820

  • 3 of 11 (27.27%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 67.713%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/cli/monitor.py 3 11 27.27%
Files with Coverage Reduction New Missed Lines %
flexmeasures/cli/monitor.py 2 28.57%
Totals Coverage Status
Change from base Build 2926621041: -0.02%
Covered Lines: 7260
Relevant Lines: 10150
💛 - Coveralls

Flix6x
Flix6x approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Besides a minor comment, I believe it's worth a changelog entry under Infrastructure / Support.

flexmeasures/cli/monitor.py Outdated Show resolved Hide resolved
flexmeasures/cli/monitor.py Show resolved Hide resolved
flexmeasures/cli/monitor.py Outdated Show resolved Hide resolved
@nhoening
changelog entry
7434f21 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
small logging improvements
15de55a 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit 537e691 into main Aug 27, 2022
@nhoening nhoening deleted the cli-monitoring-extra-message-param branch August 27, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhoening @coveralls @Flix6x