Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate that user can set the account on an asset #488

Merged
merged 5 commits into from Aug 26, 2022

Conversation

nhoening
Copy link
Contributor

Also improve UI for adding assets by non-admins

Signed-off-by: Nicolas Höning nicolas@seita.nl

…ding assets by non-admins

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening linked an issue Aug 25, 2022 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Aug 25, 2022

Pull Request Test Coverage Report for Build 2933033284

  • 20 of 21 (95.24%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 67.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/ui/views/logged_in_user.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/ui/views/logged_in_user.py 1 66.67%
Totals Coverage Status
Change from base Build 2926621041: 0.05%
Covered Lines: 7276
Relevant Lines: 10165

💛 - Coveralls

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x August 25, 2022 13:11
flexmeasures/ui/crud/assets.py Show resolved Hide resolved
flexmeasures/ui/crud/assets.py Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…to all template rendering calls

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… to those assets on the page

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x August 26, 2022 10:28
@nhoening nhoening merged commit c8903b9 into main Aug 26, 2022
@nhoening nhoening deleted the 487-validate-account-when-non-admins-create-assets branch August 26, 2022 11:50
@Flix6x Flix6x added this to the 0.11.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate account when non-admins create assets
3 participants