Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toy tutorial UI fixes #466

Merged
merged 5 commits into from Jul 21, 2022
Merged

Toy tutorial UI fixes #466

merged 5 commits into from Jul 21, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jul 21, 2022

This PR corrects 1 mistake in how the battery schedule is visualized in the UI and CLI (positive values indicate production, i.e. discharging). Two more commits make what is shown on chart tooltips easier to the eye.

…values

Signed-off-by: F.N. Claessen <felix@seita.nl>
…w that we show the unit right next to the value

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Jul 21, 2022
@Flix6x Flix6x added this to the 0.11.0 milestone Jul 21, 2022
@Flix6x Flix6x self-assigned this Jul 21, 2022
@Flix6x Flix6x requested a review from nhoening July 21, 2022 16:03
@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2022

Pull Request Test Coverage Report for Build 2713603158

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 67.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/data_sources.py 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/data_sources.py 1 52.56%
Totals Coverage Status
Change from base Build 2711605930: -0.02%
Covered Lines: 7179
Relevant Lines: 10060

💛 - Coveralls

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 1c0054b into main Jul 21, 2022
@Flix6x Flix6x deleted the toy-tutorial-ui-fixes branch July 21, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants