New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 423 improve dashboard and asset listing for admins #461
Conversation
nhoening
commented
Jul 12, 2022
- Admins can group assets on dashboard by accounts
- Admins list all assets (from all accounts) in /assets overview
…better name Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… not unique (anymore) Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
I see there is a testing problem, but the PR is nonetheless reviewable. |
…ttribute added earlier Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…lexMeasures/flexmeasures into Issue-423-improve-dashboard-for-admins
Pull Request Test Coverage Report for Build 2696744299
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's 3/4 of a review.
I think we could also discuss how the dashboard could be developed later. For example, I imagine the underlying asset data as a table (not shown, but served to the browser as a data frame) with columns name, type and owner, and the toggle button let's you switch between defining map layers based on type or based on owner. It seems like it would be cleaner to serve up the entire table once, and switch between layers on the client side only. Also, interesting applications may want to extend the table with new columns that can serve as map layers, like (from the top of my head) filtering assets into tiers based on their nominal capacity, or by how congested the area is in which they reside.
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
You are right with your general comment, but that is outside the scope of this PR. I believe this PR (next to adding some features we didn't have) opens up the way to implement such bigger steps, e.g. by refactoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the final 1/4 of my review.
Stuff about having map layers correspond to asset properties..
I agree it's for a different PR. Could you already open an issue for that and note roughly what code would need to be updated?
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…oint, so public assets can be read as well (/assets needs an account, so this is the only clean solution). Signed-off-by: Nicolas Höning <nicolas@seita.nl>
I don't see the need to open a new issue at this point. We don't know what we'll really want when we re-build the frontend. The code might change, and as it is now, it is clearer than before. |