Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from 12-hour clock to 24-hour clock in time axis labels and in tooltips #446

Merged
merged 6 commits into from Jul 8, 2022
Merged

Switch from 12-hour clock to 24-hour clock in time axis labels and in tooltips #446

merged 6 commits into from Jul 8, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 18, 2022 •
edited

Before:
image
After:
image

And for tooltips, before:
image
And after:
image

Closes #445.

@Flix6x
Switch from 12-hour clock to 24-hour clock in time axis labels and in…
183030f 
… tooltips

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Jun 18, 2022
@Flix6x
Changelog entry
91beb6e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix test
216fc26 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add redundant brackets for ease of reading
b95e901 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2022 •
edited

Pull Request Test Coverage Report for Build 2637678311

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 45 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 68.369%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/time_series.py 45 74.49%
Totals Coverage Status
Change from base Build 2611878330: -0.008%
Covered Lines: 7096
Relevant Lines: 9844
💛 - Coveralls

@Flix6x Flix6x marked this pull request as ready for review June 20, 2022 08:35
@Flix6x Flix6x requested a review from nhoening June 20, 2022 08:35
@Flix6x
Add comment explaining the chosen timeFormat
3e358c0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/main' into Issue-445_Time_series…
18de9a7 
…_axis_labels_with_24-hour_notation_instead_of_AM/PM

# Conflicts:
#	documentation/changelog.rst
#	flexmeasures/data/models/charts/defaults.py
@Flix6x Flix6x added this to the 0.11.0 milestone Jul 8, 2022
@Flix6x Flix6x merged commit 1acd3f4 into main Jul 8, 2022
@Flix6x Flix6x deleted the Issue-445_Time_series_axis_labels_with_24-hour_notation_instead_of_AM/PM branch July 8, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening requested changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Time series axis labels with 24-hour notation instead of AM/PM
3 participants
@Flix6x @coveralls @nhoening