Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve from scratch tutorial for UI views #443

Merged
merged 4 commits into from Jun 16, 2022
Merged

Improve from scratch tutorial for UI views #443

merged 4 commits into from Jun 16, 2022

Conversation

nhoening
Copy link
Contributor

No description provided.

@nhoening
better description of the UI part in the from-scratch tutorial, plus …
f3bfbd5 
…help if sudo is needed for Docker

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
allow access tokens to be passed as env vars as well
df50047 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x June 15, 2022 11:29
@coveralls
Copy link
Collaborator

coveralls commented Jun 15, 2022 •
edited

Pull Request Test Coverage Report for Build 2507504637

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.377%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/utils/config_utils.py 0 1 0.0%
Totals Coverage Status
Change from base Build 2490485088: 0.0%
Covered Lines: 7093
Relevant Lines: 9838
💛 - Coveralls

Flix6x
Flix6x approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions.

documentation/tut/toy-example-from-scratch.rst Outdated Show resolved Hide resolved
flexmeasures/utils/config_utils.py Show resolved Hide resolved
@nhoening
changelog entry
5102e9c 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
spell it 'macOS' as it is the preferred spelling
bd8d19a 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit a436797 into main Jun 16, 2022
@nhoening nhoening deleted the improve-from-scratch-tutorial-for-UI-views branch June 16, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhoening @coveralls @Flix6x