Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search filter and CLI test #414

Merged
merged 3 commits into from Apr 9, 2022
Merged

Fix search filter and CLI test #414

merged 3 commits into from Apr 9, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 8, 2022

Two fixes, one PR.

@Flix6x
Fix CLI test
952c729 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix: do not duplicate index levels in groupby
57a2eba 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working Still Needs Manual Backport labels Apr 8, 2022
@Flix6x Flix6x added this to the 0.9.2 milestone Apr 8, 2022
@Flix6x Flix6x requested a review from nhoening April 8, 2022 18:33
@Flix6x Flix6x self-assigned this Apr 8, 2022
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2022 •
edited

Pull Request Test Coverage Report for Build 2140029833

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.549%
Totals Coverage Status
Change from base Build 2096795314: 0.0%
Covered Lines: 7035
Relevant Lines: 9733
💛 - Coveralls

@Flix6x
Changelog entry
b3f3caa 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 64c6ff5 into main Apr 9, 2022
@Flix6x Flix6x deleted the fix-search-filter branch April 9, 2022 09:14
Flix6x added a commit that referenced this pull request Apr 9, 2022
@Flix6x
Backport PR #414: Fix search filter and CLI test (#414)
40b2a96 
Fix filter for selecting one deterministic belief per event, which was duplicating index levels.

* Fix CLI test

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix: do not duplicate index levels in groupby

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening