Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register percent and permille units #359

Merged
merged 3 commits into from Feb 8, 2022
Merged

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Feb 4, 2022

No description provided.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the Units Deals with unit conversion label Feb 4, 2022
@Flix6x Flix6x self-assigned this Feb 4, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening February 4, 2022 16:31
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure it would be straightforward to demonstrate this in a test?

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening February 8, 2022 16:26
@Flix6x Flix6x merged commit e1a8870 into main Feb 8, 2022
@Flix6x Flix6x deleted the support-percentage-units branch February 8, 2022 21:46
@Flix6x Flix6x added this to the 0.9.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Units Deals with unit conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants