Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 29 better visibility of map icons using markers #30

Merged
merged 6 commits into from Feb 22, 2021
Merged

Issue 29 better visibility of map icons using markers #30

merged 6 commits into from Feb 22, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Feb 18, 2021 •
edited

Just some map styling: I put map icons on top of markers and added a hover tooltip, too.

Closes #29.

@Flix6x Flix6x requested a review from nhoening February 18, 2021 21:07
@Flix6x Flix6x self-assigned this Feb 18, 2021
nhoening
nhoening requested changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really a bit better now, congrats. The only thing for me is that the tooltip that shows when clicking on the asset is not 100% visible anymore ― the upper bit is not within the map anymore.

@Flix6x Flix6x requested a review from nhoening February 19, 2021 10:20
@Flix6x Flix6x added the UI label Feb 19, 2021
@Flix6x
Copy link
Contributor Author

Flix6x commented Feb 19, 2021

I'm leaving this open a little while longer still, because I want to check the other two templates in which we use maps: asset.html and asset_new.html.

@Flix6x Flix6x merged commit f4f23d7 into main Feb 22, 2021
@Flix6x Flix6x deleted the issue-29-Better_visibility_of_map_icons_using_markers branch February 22, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better visibility of map icons using markers
2 participants
@Flix6x @nhoening