Multi-tenancy #159
Merged
Multi-tenancy #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
|
To be discussed: Can sensors be orphans? I.e. when we delete a GenericAsset, should assorted sensors be deleted automatically? For now, I found code that suggests so and followed through. |
Flix6x
requested changes
Aug 23, 2021
There was a problem hiding this comment.
Mostly I just request some documentation, and a short Marshmallow validator for account_id. I also found one or two potential small issues.
Concerning the cascading deletion of sensors and their data, rather than keeping around orphaned data, the way you implemented it here is in line with my preference. That said, I'd recommend being more explicit about the effects of deleting an account.
… & downgrading the database migration
…ke sure all test users have an account
…erived from asset.owner_id)
…he add user command. Make sure deleting GenericAssets actually csscades to deleting the connected sensors.
…account_id to /user docs
… used to delete an account
nhoening
force-pushed
the
issue-158-Multi-tenancy
branch
from
c1ef6ea
to
b95811f
Compare
|
I re-based this PR on main (should make it easier to view changes) and fixed a few small things. |
Flix6x
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #158
Upgrading the database
Verify that the current revision is
b6d49ed7ccebor higher before checking out this branch.The upgrade should be straightforward:
This will:
generic_asset.owner_idassociations (and move them togeneric_asset.account_id, using the accounts from step 1). This will be backed up locally, should you want todb downgradelater.Note:
You can add custom user-account relationships, e.g.:
This would associate users 1, 3 and 30 to accounts with the names "Seita", "CustomerA" and "CustomerB", respectively, creating these accounts on the go.