New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DarkSky API replacement #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code (minor requests only I believe). I did not test it. Let me know how to best do that if you want me to.
@Flix6x Another comparison, now the temperature readings from our call to OWM, and a screenshot from the OWM website. Here we want to see if we catch their data at the right time. In our database we see UTC times, which are two hours behind current Amsterdam time. Looks to me like the data is the correct data at the correct time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments.
closes #3