Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset and sensor pages sometimes showing no data on page load #468

Closed
nhoening opened this issue Jul 23, 2022 · 2 comments · Fixed by #472
Closed

Asset and sensor pages sometimes showing no data on page load #468

nhoening opened this issue Jul 23, 2022 · 2 comments · Fixed by #472
Assignees
Labels
bug Something isn't working UI
Milestone

Comments

@nhoening
Copy link
Contributor

I seem to experience a bug with the data being displayed on the asset page. It's not reliably reproducible and seems to be worse on Firefox than on Chrome :/

I load the page, and I refresh (F5). Often, the data is not showing (even though it seems to be fetched, looking at the networking console). Selecting a date in the datepicker then works - most of the time.
I refreshed a few times, and there seemed even to be some randomness in this bug.

Data might sometimes appear shortly and then disappear (maybe a rendering problem with all the layers we're making?)

I noticed this when reviewing #467, but I also see it on main. I tried Firefox and Chrome. The latter seems better for the first few reloads, but then also regresses for me.

I'm attaching two screenshots, they were made on Firefox, and on the main branch, after a hard reset (Ctrl-Shift-F5)

no-data-shown-but-data-was-fetched
no-data-some-js-errors

@nhoening nhoening added bug Something isn't working UI labels Jul 23, 2022
@nhoening nhoening modified the milestones: 0.10.1, 0.11.0 Jul 23, 2022
@nhoening
Copy link
Contributor Author

nhoening commented Jul 23, 2022

A screenshot from when it worked (selecting the day with data in the picker)

network-from-a-time-data-is-shown

@Flix6x
Copy link
Contributor

Flix6x commented Aug 8, 2022

I'm running FlexMeasures locally on commit 7874bd7 and looking at the toy-battery asset in Firefox and Chrome.

I have been able to reproduce this bug for the sensor page (as you mentioned it in the issue title). The chart on the sensor page does not have multiple layers, so I don't think it has to do with the layers. It looks like the vegaView variable isn't defined yet when the data fetching promises are done. I'll need to make sure the variable is set up before any of the promises's then blocks try to load the view with data.

So far I haven't been able to reproduce this bug for the asset page, but I'll make sure to implement the fix for both pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
2 participants