Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of bar charts #332

Closed
Flix6x opened this issue Jan 21, 2022 · 3 comments
Closed

Fix resolution of bar charts #332

Flix6x opened this issue Jan 21, 2022 · 3 comments

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Jan 21, 2022

Merging PR #310 seems to have failed, in the end leaving only its changelog entry on main.

@nhoening
Copy link
Contributor

Weird. The merge commit still looks okay, but the PR reports only the changelog entry.

Btw, adding ".diff" to a URL can give you a diff file which you can apply locally: https://github.com/FlexMeasures/flexmeasures/commit/fd848f09565566b568e85588cf0e2b8dcd86c8a8.diff

@nhoening
Copy link
Contributor

The Unix patch command should help applying such a diff file.

@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 21, 2022

Huh, upon further inspection it looks like the changes are actually already incorporated on main. It seems as if my pre-merge (from project-9 into the dev branch for PR #310) ended up moving the meat of that PR into PR #313.

@Flix6x Flix6x closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants