Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pint to check and convert units #282

Closed
3 tasks done
Flix6x opened this issue Dec 21, 2021 · 0 comments · Fixed by #283
Closed
3 tasks done

Use pint to check and convert units #282

Flix6x opened this issue Dec 21, 2021 · 0 comments · Fixed by #283

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Dec 21, 2021

Goal is to support other (power) units throughout FlexMeasures, e.g. by converting incoming data to the sensor unit, and outgoing data to the requested unit.

The pint-pandas package doesn't work too nicely with all of the pandas operations we use in timely-beliefs, so instead I propose to use pint on Sensor.unit, instead of on BeliefsDataFrame["event_values"]. I'd also like to keep the Sensor.unit database column as is, i.e. storing the shorthand string representation of units (e.g. MW, m/s and EUR/kWh).

I've identified some issues that would need to be resolved in order for this to work smoothly, solutions for which are all within reach:

@Flix6x Flix6x linked a pull request Dec 22, 2021 that will close this issue
@Flix6x Flix6x closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant