New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve checks for FlexMeasures' own config settings based on checks for plugin config settings #236
Comments
@nhoening suggested the following files for the
Given that our settings specification now looks like the example below, I'd prefer to keep all config settings together, and not just the required ones. I can also imagine it makes sense to just extend the specification with a
|
I thought about this avenue for a bit, but it changes the way we load settings in a larger way. There are many settings FlexMeasures relies on, many even defined in other packages. |
What about "just" the ones we mention in https://flexmeasures.readthedocs.io/en/latest/configuration.html? |
Those are all we list in the config_default module I believe. I counted 53. I counted ten among them which are required (e.g. databases) or recommended (e.g. mail). So that is the lower boundary. |
From discussion in #230.
Foremost, we want to improve how we encode config settings requirements and replace
config_utils.are_required_settings_complete
andconfig_utils.get_config_warnings
with functionality we use to check config settings registered by plugins. This means we'll then be able to more expressively define our expected config settings.Secondly, configs are growing up within FlexMeasures, so we may want to refactor to give configs their own
config
sub-package.The text was updated successfully, but these errors were encountered: