Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No confirmation to discard unsaved segment or feature creation modals #3921

Open
rolodato opened this issue May 10, 2024 · 0 comments · May be fixed by #3979
Open

No confirmation to discard unsaved segment or feature creation modals #3921

rolodato opened this issue May 10, 2024 · 0 comments · May be fixed by #3979
Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers improvement

Comments

@rolodato
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When creating or editing segments, you can click the X at the top right or click anywhere outside of the modal to close the modal. This will immediately destroy any unsaved changes without requiring confirmation. This is error prone and can be very frustrating. Example (same thing happens when editing):

segment-confirmation.mov

We do require confirmation for discarding unsaved features, and also mark the tabs with pending changes (the icon besides the Value and Segment Overrides tab headers) - but only for feature editing and not creation.

image

Describe the solution you'd like.

Require confirmation to close any feature or segment modal with unsaved changes.

Describe alternatives you've considered

One option might be, only for creation modals: do not require confirmation to close them, but restore the previous state if the same modal is opened again. This is probably a lot more effort than it's worth, needs to account for multiple organisations/projects, navigating away from the page or refreshing, could potentially store unwanted sensitive data etc.

Additional context

No response

@rolodato rolodato changed the title No confirmation to discard unsaved segment modals No confirmation to discard unsaved segment or feature creation modals May 10, 2024
@matthewelwell matthewelwell added good first issue Good for newcomers improvement front-end Issue related to the React Front End Dashboard labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants