Add named error codes and their corresponding messages #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
requested changes
Dec 19, 2023
| /// </summary> | ||
| public partial class FbErrorCodes | ||
| { | ||
| public static string GetMessage(int code) => |
There was a problem hiding this comment.
These messages are already part of exception message (from IscErrorMessages.cs).
| /// <summary> | ||
| /// Error codes occuring in Firebird database management system. | ||
| /// | ||
| /// Messages are taken from documentation at: https://ib-aid.com/download/docs/firebird-language-reference-2.5/fblangref25-appx02-sqlcodes.html |
There was a problem hiding this comment.
Rather take it from Firebird sources. For completeness and copyright sake. Add also some simple steps how the file/data was created. Something rough like this is fine.
I would maybe even keep the "raw" naming like arith_except from https://github.com/FirebirdSQL/firebird/blob/65f0e8b4f1b346b436456bf74d954c2e8204076f/src/include/firebird/impl/msg/jrd.h#L2.
Maybe worth updating also IscErrorMessages and SqlStateMapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two files representing FbErrorCodes static class.
I have taken codes and messages from https://ib-aid.com/download/docs/firebird-language-reference-2.5/fblangref25-appx02-sqlcodes.html.
Might close #1148 .