Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

102 patternmarkers all returning empty lists #103

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

102 patternmarkers all returning empty lists #103

wants to merge 22 commits into from
+168 −132

Conversation

dimalvovs
Copy link
Contributor

  • add a test that fails on empty patterMarkers
  • make it pass by rewriting the method for threshold='all'

@dimalvovs dimalvovs linked an issue May 2, 2024 that may be closed by this pull request
patternMarkers 'all' returning empty lists #102
Open
@dimalvovs
Copy link
Contributor Author

@kwoyshner can you review please?

@kwoyshner
Copy link

I tried reinstalling from this branch and was able to get patternMarkers with 'all' now, thank you!

@dimalvovs
Copy link
Contributor Author

@kwoyshner do you want to have a look at threshold = 'cut'? I've updated it too. This part of code is poorly documented so I was not sure what that mode should do but there was a dimension mismatch. simplicityGENES function needs to be inspected for functionality.

@dimalvovs dimalvovs marked this pull request as ready for review May 5, 2024 22:50
jmitchell81
jmitchell81 approved these changes May 8, 2024
View reviewed changes
R/methods-CogapsResult.R Show resolved Hide resolved
drbergman
drbergman reviewed May 8, 2024
View reviewed changes
Copy link

@drbergman drbergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unqualified to comment on how these changes affect the integrity of the CoGAPS algorithm, but I left a few comments. Hopefully, it helps in some small way!

R/methods-CogapsResult.R Outdated Show resolved Hide resolved
R/methods-CogapsResult.R Outdated Show resolved Hide resolved
tests/testthat/test_output_across_modes.R Outdated Show resolved Hide resolved
@dimalvovs dimalvovs requested a review from genesofeve May 9, 2024 21:30
genesofeve
genesofeve reviewed May 29, 2024
View reviewed changes
R/class-CogapsResult.R Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reinstate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genesofeve genesofeve genesofeve left review comments

@drbergman drbergman drbergman left review comments

@jmitchell81 jmitchell81 jmitchell81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

patternMarkers 'all' returning empty lists
5 participants
@dimalvovs @kwoyshner @genesofeve @drbergman @jmitchell81