Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in Version.equals() if snapshot-info null #1141

Closed
TimSchweers opened this issue Nov 21, 2023 · 1 comment
Closed

NPE in Version.equals() if snapshot-info null #1141

TimSchweers opened this issue Nov 21, 2023 · 1 comment
Labels
2.16 Issue planned (at earliest) for 2.16
Milestone
2.16.1

Comments

@TimSchweers
Copy link

Hi!

The Version.equals implementation updated with 2.16.0 for comparing snapshots raises an NPE if snapshotInfo is null.
I recommend to sanitize the snapshoptInfo within constructor as done for groupId and artifactId.
@cowtowncoder cowtowncoder added the 2.16 Issue planned (at earliest) for 2.16 label Nov 21, 2023
@cowtowncoder
Copy link
Member

Thank you for reporting this @TimSchweers . Yes, that sounds like a good idea to handle (regardless of whether to sanitize or null-check in equals()), avoid NPE.

@cowtowncoder cowtowncoder changed the title NPE in Version.equals NPE in Version.equals() if snapshot-info null Nov 22, 2023
cowtowncoder added a commit that referenced this issue Nov 22, 2023
@cowtowncoder
Fix #1141: prevent NPE in Version.equals()
607f59d
@cowtowncoder cowtowncoder added this to the 2.16.1 milestone Nov 22, 2023
dmikurube added a commit to embulk/embulk-util-config that referenced this issue Apr 3, 2024
@dmikurube
Fix TestVersion for Jackson 2.16 and 2.17
8e5841e 
The test has started to fail since Jackson 2.16.0 because of the following changes:

- FasterXML/jackson-core#1053
- FasterXML/jackson-core#1142

These were "fixing" the following issues:

- FasterXML/jackson-core#1050
- FasterXML/jackson-core#1141
@dmikurube dmikurube mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.16 Issue planned (at earliest) for 2.16
Projects
None yet
Milestone
2.16.1
Development

No branches or pull requests
2 participants
@cowtowncoder @TimSchweers