Pass cluster configuration to adminconfig #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,9 +18,13 @@ public ClusterManager(ILogHandler logHandler, ClusterConfiguration configuration | |||
| { | |||
| this.logHandler = logHandler; | |||
| this.configuration = configuration; | |||
| var adminConfig = new AdminClientConfig() | |||
There was a problem hiding this comment.
Since AdminClientBuilder is lazy, can we move the initialization of AdminClientConfig under the lazy initialization?
Something like this:
this.lazyAdminClientBuilder = new Lazy<AdminClientBuilder>(
() =>
{
var adminConfig = new AdminClientConfig()
{
BootstrapServers = string.Join(",", configuration.Brokers),
};
adminConfig.ReadSecurityInformationFrom(configuration);
return new AdminClientBuilder(adminConfig);
});
| @@ -70,5 +70,42 @@ public static void ReadSecurityInformationFrom(this ClientConfig config, Cluster | |||
| config.SaslUsername = securityInformation.SaslUsername; | |||
| config.SaslPassword = securityInformation.SaslPassword; | |||
| } | |||
|
|
|||
| public static void ReadSecurityInformationFrom(this AdminClientConfig config, ClusterConfiguration cluster) | |||
There was a problem hiding this comment.
Since AdminClientConfig inherits from ClientConfig the extension method ReadSecurityInformationFrom(this ClientConfig config, ClusterConfiguration cluster) can be reused.
|
This change was made in #419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass cluster config to AdminClient
Fixes #380
How Has This Been Tested?
Tested to create topic.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement