Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per user tag added to sonarr & radarr includes user id number #727

Open
1 task done
noybman opened this issue Apr 21, 2024 · 4 comments
Open
1 task done

Per user tag added to sonarr & radarr includes user id number #727

noybman opened this issue Apr 21, 2024 · 4 comments

Comments

@noybman
Copy link

noybman commented Apr 21, 2024

Description

Please remove "USER NUMBER" from the User tagging being sent to the *arr.

Feature of tagging requests in the *arr with the user who requested it (#201) works well.
It lists the Jellyseerr "ID" a "space dash space" "Jellyseerr username" in the arr. So user #13 with a name of "TomJones" will show up in the arr next to the title as "13 - TomJones". In ombi, it would just list "TomJones".

While there may be some use case to having the ID number listed, I can say for sure, there is also use case for it to not be listed.

Desired Behavior

A more powerful and truly flexible solution would be to:

When user tagging is enabled:
allow the administrator of Jellyseerr to chose the format of said tag... to include:

  1. PREFIX_TEXT (optional)
    
  2. ID# (required if USERNAME is not selected, otherwise optional)
    
  3. SEPARATOR (text, optional but only enables if ID# and USERNAME is selected)
    
  4. USERNAME (required if ID# is not selected, otherwise optional)
    
  5. SUFFIX_TEXT (optional)
    

This would allow the existing behavior, as well as allow the admin flexibility over the tags being added to other applications including the case matching ombi's behavior.

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@Fallenbagel
Copy link
Owner

Fallenbagel commented Apr 21, 2024

There are a lot of useful cases though. It gives you the id, like you don't have to look up that id on jellyseerr (and stat nerds)

@noybman
Copy link
Author

noybman commented Apr 21, 2024

I'm not familiar with the API, but I would have thought a user ID or a USERNAME would be sufficient. in this case, if someone is using that tag for api purposes, they have to parse it anyways. (string split on " - " and trim() ... for example).....

Also, that ID is the Jellyseerr ID, not the Emby ID. The name really is sufficient. At least in any immediate case I can think of.

Given that perhaps the ID is all someone cares about (or the name is all someone cares about) perhaps the feature request should be:

If TAGS is enabled for user requests - then:
allow the administrator of Jellyseerr to chose the format of said tag... to include:

  1. PREFIX_TEXT (optional)
  2. ID# (required if USERNAME is not selected, otherwise optional)
  3. SEPARATOR (text, optional but only enables if ID# and USERNAME is selected)
  4. USERNAME (required if ID# is not selected, otherwise optional)
  5. SUFFIX_TEXT (optional)

this would cover all cases. Especially the one where the ID's and separators are being used (as is currently implemented) and is not useful (as Im willing to wager a strong guess it isn't useful to others either, they just take note of the # and use it when filtering) in an *arr, or jellyfin etc.

@Fallenbagel
Copy link
Owner

Fallenbagel commented Apr 21, 2024

I'm not familiar with the API, but I would have thought a user ID or a USERNAME would be sufficient. in this case, if someone is using that tag for api purposes, they have to parse it anyways. (string split on " - " and trim() ... for example).....

Not everyone's specification for something is the same. Majority of people might want it as it currently is even if you don't.

Also, that ID is the Jellyseerr ID, not the Emby ID. The name really is sufficient. At least in any immediate case I can think of.

Ditto on what I said last time.

Given that perhaps the ID is all someone cares about (or the name is all someone cares about) perhaps the feature request should be:

If TAGS is enabled for user requests - then:
allow the administrator of Jellyseerr to chose the format of said tag... to include:

  1. PREFIX_TEXT (optional)
  2. ID# (required if USERNAME is not selected, otherwise optional)
  3. SEPARATOR (text, optional but only enables if ID# and USERNAME is selected)
  4. USERNAME (required if ID# is not selected, otherwise optional)
  5. SUFFIX_TEXT (optional)

If this is the desired feature request, please update the feature request's desired behavior to reflect that.

@noybman
Copy link
Author

noybman commented Apr 21, 2024

I can't speak for what the majority would want; but since the bulleted list give quite a bit of flexibility I think its a good start. thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants