Skip to content
This repository has been archived by the owner on Jul 8, 2021. It is now read-only.

allow number format with leading zero #19

Open
muescha opened this issue Dec 28, 2017 · 7 comments · May be fixed by #468
Open

allow number format with leading zero #19

muescha opened this issue Dec 28, 2017 · 7 comments · May be fixed by #468

Comments

@muescha
Copy link

muescha commented Dec 28, 2017

what i do:

  • i downloaded a section
  • i open VLC
  • i select "Advanced File open"
  • i selected the folder of a section

what i see:

  • when there are lectures with >9 numbers
  • then the lecture 10 start right after lection 1

what i expect

  • lectures in right order

how to fix:

  • allow lecture and section numbers formatte with leading zero:
    1 --> 001
    2 --> 002
    10 --> 010
@FaisalUmair
Copy link
Owner

FaisalUmair commented Dec 28, 2017

Yeah I have seen this numbering scheme implemented in some of the scripts which download Udemy courses. I never understood why they use leading zeros but now I know.

But if we generate a playlist per course and per section of course? Do you think we still need the leading zeros?

Thanks

@muescha
Copy link
Author

muescha commented Dec 28, 2017

i think some other apps (and the windows explorer ) not sort it right without a leeding zero.
so it is a low hanging fruit to make an option "add leading zeros" to get it work ;)

@muescha
Copy link
Author

muescha commented Dec 28, 2017

or maybe on windows by default on.

for #16 you should be aware that someone changed this setting while download sessions.

@FaisalUmair
Copy link
Owner

I think you are right, better to implement it as it wont hurt as anyway.

@tofanelli
Copy link

i totally agree with this naming schema =)

@FredThompsonII
Copy link

yes, use leading zeros for compatibility.

@oscarreno
Copy link

Maybe this issue can be joined with

[(https://github.com//issues/317)]

In fact, my comment there is in the same line of what is written here.

[https://github.com//issues/317#issuecomment-690767290]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants